Fixes for PyArrow #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assorted fixes and improvements: * ensure the entire test suite passes under Linux * add `--no-patch` option to disable the DLL patch patching logic * add `--mangle-only` option to select individual DLL to name-mangle * dependencies already in the wheel are not copied into `<distname>.libs` anymore
|
This PR is probably not fit for merging (it lacks unit tests). If there is consensus on some of the changes, I can file individual PRs for them. |
Closed
|
I'm realizing there is a |
pitrou
added a commit
to apache/arrow
that referenced
this pull request
Jan 4, 2025
…#35323) ### Rationale for this change We need to ship the C++ standard library with our Windows wheels, as it is not guaranteed that a recent enough version is present on the system. However, some other Python libraries may require an even more recent version than the one we ship. This may incur crashes when PyArrow is imported before such other Python library, as the older version of the C++ standard library would be used by both. ### What changes are included in this PR? Use a [fixed-up version](adang1345/delvewheel#59) of delvewheel that allows us to name-mangle an individual DLL, and name-mangle `msvcp140.dll` to ensure that other Python libraries do not reuse the version we ship. ### Are these changes tested? By regular wheel build tests. * Closes: #44855 * GitHub Issue: #33981 * GitHub Issue: #44855 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
Let me know whether 0bc542d solves the problem for your use case. It adds an option to mangle the names of direct dependencies of DLLs that are already in the wheel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted fixes and improvements:
--no-patchoption to disable the DLL search path patching logic--mangle-onlyoption to select individual DLL to name-mangle<distname>.libsanymore