-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/report: detect unused exclusions #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seilagamo
force-pushed
the
not-matched-exclusions
branch
2 times, most recently
from
August 23, 2024 10:11
bc9dd39
to
58948df
Compare
jroimartin
force-pushed
the
not-matched-exclusions
branch
from
August 23, 2024 11:48
12c6c93
to
2f7bb5a
Compare
seilagamo
force-pushed
the
not-matched-exclusions
branch
2 times, most recently
from
August 23, 2024 14:20
6df5263
to
b19080a
Compare
jroimartin
requested changes
Aug 26, 2024
jroimartin
requested changes
Aug 29, 2024
jroimartin
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Just a couple of nitpicks. Also, clean up the commit history.
seilagamo
force-pushed
the
not-matched-exclusions
branch
from
August 30, 2024 08:54
775960c
to
0fff6d5
Compare
jroimartin
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lava outputs a warning if an exclusion rule does not match any finding.
A new parameter,
error_on_stale_exclusions,
has been added to the configuration if we want to exit with an exit code when there are unused exclusions.The goal is to avoid staled exclusion rules.