fix(textfield): char counter now displays even if no helper is provided #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
soulcramer
force-pushed
the
sr-branch-2
branch
from
66e2390 to
905a303
Compare
soulcramer
added a commit
that referenced
this pull request
Jan 28, 2025
…ed (#1445) (cherry picked from commit da5546b) Signed-off-by: Scott Rayapoullé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Display character counter even if no state message or helper message is provided.
Add a snapshot test to cover this regression.
🤔 Context
Closes SPA-490
✅ Checklist
spark-designGitHub team.📸 Screenshots
See the new snapshot test in the changed files