Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-apps): Remove deprecated argocd-notifications component #1364

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 5 additions & 28 deletions charts/argo-apps/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: argo-apps
description: Argo CD app-of-apps config for various argo project components
type: application
version: 0.25.0
version: 0.26.0
home: https://github.com/adfinis/helm-charts/tree/main/charts/argo-apps
sources:
- https://github.com/adfinis/helm-charts
Expand All @@ -17,30 +17,7 @@ dependencies:
annotations:
artifacthub.io/changes: |
- kind: changed
description: "feat(argo-rollouts): update from 1.7.0 to 1.7.2"
links:
- name: GitHub Release 1.7.1
url: https://github.com/argoproj/argo-rollouts/releases/tag/v1.7.1
- name: GitHub Release 1.7.2
url: https://github.com/argoproj/argo-rollouts/releases/tag/v1.7.2
- kind: changed
description: "feat(argo-rollouts): update chart from 2.36.0 to 2.38.0"
links:
- name: "fix: Change type of trafficRouterPlugins and trafficRouterPlugins as list"
url: https://github.com/argoproj/argo-helm/pull/3036
- name: "fix: plugin block rendering"
url: https://github.com/argoproj/argo-helm/pull/3014
- name: "feat: Add loadBalancerClass field for Service resources"
url: https://github.com/argoproj/argo-helm/pull/2772
- name: "fix: Align permissions for controller's ClusterRole / Role"
url: https://github.com/argoproj/argo-helm/pull/2830
- name: "feat: add option to disable creation of notifications configmap"
url: https://github.com/argoproj/argo-helm/pull/2849
- name: "fix: Add traefik apiGroup"
url: https://github.com/argoproj/argo-helm/pull/2703
- name: "fix: fix global subscriptions for Rollouts"
url: https://github.com/argoproj/argo-helm/pull/2797
- name: "fix: add subscriptions in notifications configmap"
url: https://github.com/argoproj/argo-helm/pull/2793
- name: "fix: add annotations for notificactions secret"
url: https://github.com/argoproj/argo-helm/pull/2777
description: |
Remove deprecated Argo CD Notifications App.

The functionality has been merged into the main Argo CD application.
3 changes: 1 addition & 2 deletions charts/argo-apps/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions charts/argo-apps/templates/argocd-notifications.yaml

This file was deleted.

13 changes: 0 additions & 13 deletions charts/argo-apps/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,6 @@ argoconfig:
# -- Optional annotations to add to all Applications metadata.
annotations: {}

# -- [Argo CD Notifications](https://argocd-notifications.readthedocs.io/en/stable/) is DEPRECATED, use Argo CD directly instead.
# @default -- DEPRECATED
argocdNotifications:
enabled: false
name: argocd-notifications
annotations: {}
destination:
namespace: "infra-argocd"
repoURL: "https://argoproj.github.io/argo-helm"
chart: "argocd-notifications"
targetRevision: "1.8.*"
values: {}

# -- [Argo Rollouts](https://argoproj.github.io/argo-rollouts/) ([example](./examples/argo-rollouts.yaml))
# @default -- -
argoRollouts:
Expand Down
Loading