Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infra-apps): Add fail for kube-event-exporter deprecation #1365

Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore(infra-apps): Add fail for kube-event-exporter deprecation #1365

merged 1 commit into from
Jan 28, 2025

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jan 16, 2025 •
edited
Loading

Description

We marked kube-event-exporter as deprecated >6 months ago, next we fail if users still need it.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2025
@hairmare hairmare force-pushed the chore/infra-apps/fail-kube-event-exporter-as-deprecated branch 3 times, most recently from fccf253 to 8a52aa6 Compare January 16, 2025 17:27
@hairmare hairmare force-pushed the chore/infra-apps/fail-kube-event-exporter-as-deprecated branch from 8a52aa6 to f8eaf5b Compare January 28, 2025 19:01
@hairmare hairmare marked this pull request as ready for review January 28, 2025 19:03
@hairmare hairmare requested a review from a team as a code owner January 28, 2025 19:03
@hairmare hairmare requested review from cfi2017 and vmaillot January 28, 2025 19:03
cfi2017
cfi2017 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@cfi2017 cfi2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hairmare hairmare merged commit dfe09a9 into main Jan 28, 2025
3 checks passed
@hairmare hairmare deleted the chore/infra-apps/fail-kube-event-exporter-as-deprecated branch January 28, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfi2017 cfi2017 cfi2017 approved these changes

@vmaillot vmaillot Awaiting requested review from vmaillot vmaillot is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @cfi2017