-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(security-apps): Fail deprecated gangway installations #1366
Conversation
da243a5
to
8236801
Compare
@@ -2,7 +2,7 @@ apiVersion: v2 | |||
name: security-apps | |||
description: Argo CD app-of-apps config for security applications | |||
type: application | |||
version: 0.89.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo this should be a minor release, not a patch release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Else if someone is using 0.89.* their deployment may fail without user interaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there still folks that do have x.z.*
, i thought we deprecated that ages ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a public chart, so we may not be the only consumers. It's also a breaking change in a patch version. A minor version is more of a signal that "hey, we may need to change something" for consumers so I believe it's a better fit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, i finally got to updating the PR to bump the minor and not the patch version.
I totally agree with you in principal, the main reason i asked was because we used to employ the x.y.*
all over the place and we started retiring it's use a few years back.
8236801
to
9861a79
Compare
9296af4
to
0b6ebf0
Compare
0b6ebf0
to
16d7ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
16d7ca1
to
a6aa949
Compare
Description
Gangway has been marked as deprecated for more than 6 months and now is the time to make it fail.
Issues
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/