chore(logging-apps): Fail deprecated loki-stack installations #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
hairmare
force-pushed
the
chore/logging-apps/fail-deprecated-loki-stack-installations
branch
from
787b0f6 to
6e2ff81
Compare
cfi2017
requested changes
Jan 16, 2025
| @@ -1,33 +1,3 @@ | |||
| {{ if .Values.lokiStack.enabled }} | |||
| {{ template "argoconfig.application" (list . "logging-apps.lokiStack") }} | |||
| {{ fail "loki-stack is DEPRECATED, uuse `loki` and `promtail` individually" }} | |||
There was a problem hiding this comment.
Suggested change
| {{ fail "loki-stack is DEPRECATED, uuse `loki` and `promtail` individually" }} | |
| {{ fail "loki-stack is DEPRECATED, use `loki` and `promtail` individually" }} |
There was a problem hiding this comment.
fixed and rebased
charts/logging-apps/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: logging-apps | |||
| description: Argo CD app-of-apps config for logging applications | |||
| type: application | |||
| version: 0.35.0 | |||
| version: 0.35.1 | |||
There was a problem hiding this comment.
imo this should be a minor version, as it's a potentially breaking change
There was a problem hiding this comment.
I updated this.
Users should keep in mind that the -apps charts have been doing https://0ver.org/ without any goal to change that.
hairmare
force-pushed
the
chore/logging-apps/fail-deprecated-loki-stack-installations
branch
2 times, most recently
from
2f18361 to
e499a24
Compare
hairmare
force-pushed
the
chore/logging-apps/fail-deprecated-loki-stack-installations
branch
from
e499a24 to
f069948
Compare
hairmare
deleted the
chore/logging-apps/fail-deprecated-loki-stack-installations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loki-stack installation has been marked as deprecated for more than 6 months and it gets to fail now.
Issues
Checklist
artifacthub.io/changesannotation inChart.yaml, check the example in the documentation.pre-commit rundocs/