Added Test Case for Document of Record generation #1007

barshat7 · 2023-12-05T07:07:08Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

rismehta · 2023-12-05T07:35:38Z

ui.tests/test-module/specs/documentOfRecordTest.spec.js

+ */
+
+describe('Document of Record Test', () => {
+  const formId = "L2NvbnRlbnQvZm9ybXMvYWYvY29yZS1jb21wb25lbnRzLWl0L3NhbXBsZXMvZG9jdW1lbnQtb2YtcmVjb3JkL2Rvci1mb3Jt";


Please get the form id from list forms API, you can check here for reference,

aem-core-forms-components/ui.tests/test-module/libs/support/commands.js

Line 421 in 06405e5

return cy.request("GET", `/adobe/forms/af/listforms?cursor=${cursor}&limit=${limit}`).then(({body}) => {

. formId is an implementation detail and it should not be exposed to customer,

rismehta · 2023-12-07T02:32:13Z

ui.tests/test-module/specs/documentOfRecordTest.spec.js

+        };
+        if (cy.af.isLatestAddon()) {
+          // use cursor based API if latest AddOn
+          getFormId(formPath, "", 20)


you do not need to set a limit

rismehta · 2023-12-07T02:32:41Z

ui.tests/test-module/specs/documentOfRecordTest.spec.js

+          cursor = body.cursor;
+          return getFormId(path, cursor, limit);
+        } else {
+          throw new Error("form not found");


Test case is throwing an error

rismehta · 2023-12-07T02:32:52Z

ui.tests/test-module/specs/documentOfRecordTest.spec.js

+  }
+
+  // Use this API if forms addon is old
+  const getFormIdDeprecated = (path, offset = 0, limit = 20) => {


Can you remove this, it is not required.

rismehta

check comments

codecov · 2023-12-07T08:24:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5ef16a) 80.29% compared to head (6f1b68f) 80.29%.

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1007   +/-   ##
=========================================
  Coverage     80.29%   80.29%           
  Complexity      729      729           
=========================================
  Files            89       89           
  Lines          2045     2045           
  Branches        271      271           
=========================================
  Hits           1642     1642           
  Misses          251      251           
  Partials        152      152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rismehta · 2023-12-07T12:05:48Z

...ent-of-record/dor-form/_jcr_content/renditions/cq5dam.thumbnail.140.100.png.dir/.content.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>


Can you remove the thumbnails from the test collateral ?

rismehta

check comments

Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Use list form api to get form Id Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation

* Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Use list form api to get form Id Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation Added Test Case for Document of Record generation * DOR Test check * Added Test case for Document of Record generation * Skipping DOR generation test until DOR enabled in CI

barshat7 force-pushed the dor-test branch from 254eb1b to 9e0862f Compare December 5, 2023 07:09

barshat7 requested a review from rismehta December 5, 2023 07:09

rismehta reviewed Dec 5, 2023

View reviewed changes

barshat7 force-pushed the dor-test branch from 9e0862f to f89c07f Compare December 5, 2023 09:40

rismehta reviewed Dec 7, 2023

View reviewed changes

rismehta requested changes Dec 7, 2023

View reviewed changes

barshat7 force-pushed the dor-test branch from 6501a6f to a117532 Compare December 7, 2023 07:53

barshat7 requested a review from rismehta December 7, 2023 08:25

rismehta reviewed Dec 7, 2023

View reviewed changes

rismehta requested changes Dec 7, 2023

View reviewed changes

barshat7 force-pushed the dor-test branch from 55ab90f to 123eefe Compare December 11, 2023 10:03

github-actions bot force-pushed the dor-test branch from 123eefe to 818ac5e Compare December 11, 2023 10:04

barshat7 force-pushed the dor-test branch from 818ac5e to 5b67e01 Compare December 11, 2023 11:43

github-actions bot force-pushed the dor-test branch from 5b67e01 to c68f206 Compare December 11, 2023 11:44

barshat7 force-pushed the dor-test branch from c68f206 to ca992ab Compare December 12, 2023 08:04

github-actions bot force-pushed the dor-test branch from ca992ab to 37da91f Compare December 12, 2023 08:04

barshat7 force-pushed the dor-test branch from 37da91f to 08aee28 Compare December 12, 2023 08:53

barshat7 added 4 commits December 12, 2023 08:54

DOR Test check

0048f6c

Added Test case for Document of Record generation

b427e04

Skipping DOR generation test until DOR enabled in CI

6f1b68f

github-actions bot force-pushed the dor-test branch from 08aee28 to 6f1b68f Compare December 12, 2023 08:54

rismehta approved these changes Dec 12, 2023

View reviewed changes

rismehta merged commit c111101 into dev Dec 12, 2023
4 checks passed

rismehta deleted the dor-test branch December 12, 2023 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Test Case for Document of Record generation #1007

Added Test Case for Document of Record generation #1007

barshat7 commented Dec 5, 2023

rismehta Dec 5, 2023

rismehta Dec 7, 2023

rismehta Dec 7, 2023

rismehta Dec 7, 2023

rismehta left a comment

codecov bot commented Dec 7, 2023 •

edited

Loading

rismehta Dec 7, 2023

rismehta left a comment

Added Test Case for Document of Record generation #1007

Added Test Case for Document of Record generation #1007

Conversation

barshat7 commented Dec 5, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

rismehta Dec 5, 2023

Choose a reason for hiding this comment

rismehta Dec 7, 2023

Choose a reason for hiding this comment

rismehta Dec 7, 2023

Choose a reason for hiding this comment

rismehta Dec 7, 2023

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 7, 2023 • edited Loading

Codecov Report

rismehta Dec 7, 2023

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 7, 2023 •

edited

Loading