Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-12022 initial commit for dynamic container component #1008

Closed
wants to merge 359 commits into from

Conversation

im-shiv
Copy link
Contributor

@im-shiv im-shiv commented Dec 6, 2023

No description provided.

nit23uec and others added 30 commits January 9, 2023 22:49
* Fresh collateral setup and new test suite for repeatability tests

* Dam assets

* Updated collateral with Mandatory required and rule for radiobtn to generate error msg

* Force error in each field

* CQ-4351709 SPA editor changes
- updating af core
                    @review @vdua
                    DOD(Yes)

* CQ-4351709 SPA editor changes
    - updating jest to use ESM modules inside CJS
                        @review @vdua
                        DOD(Yes)

* CQ-4348824 Support of Repeatable Panel inside Repeatable Panel. (#450)

* CQ-4348824 Support of Repeatable Panel inside Repeatable Panel.

* CQ-4348824 Support of Repeatable Panel inside Repeatable Panel.

* Increasing the af-core version

* Pulled dev

* Pulled dev

---------

Co-authored-by: Sakshi Arora <[email protected]>

* function for duplicateID test

* Repeatability check

* CQ-4351658 Repeatability with site container inside repeatable panel … (#463)

* CQ-4351658 Repeatability with site container inside repeatable panel and outside repeatable panel.

* CQ-4351658 Repeatability with site container inside repeatable panel and outside repeatable panel.

---------

Co-authored-by: Sakshi Arora <[email protected]>

* Moving some tests to improve reset tests

* CQ-4351811 & CQ-4351956 - Addition of empty/filled class based on field content and File Attachment dialog fix (#452)

* Incorporated more components and updated collateral

* @releng enable test run against latest far (#469)

* @releng enable test run against latest far

* @trivial Adding classifier

* @trivial fixing a flaky test

* [CQ-4351961] rectified duplicate id scenarios for widgets of components in repeatable panels

* [CQ-4351961] uncommented duplicate id test and rectified issues for tabsOnTop....

* CQ-4349591 [Repeatability] Unable to initialize form using Bank API FDM schema. (#465)

* [CQ-4351961] made syncWidget private api, incorporated review comments......

* [[CQ-4351961] incorporated minor review comments.......

* remove redundant ids from markup

* [CQ-4351961] removed ids where not necessary and change id updation logic to make it more generic.....

* [CQ-4351961] removed ids from checkbox and radiobutton, changed id format of tabs to be in parity with wizard.....

* [CQ-4351961] fixed test cases to assert using view rather than ids for label,errordiv.short & long description

* [CQ-4351961] fixed test cases to assert using view rather than ids for label,errordiv.short & long description

* [CQ-4351961] cahced ids of tabs and wizard elements to use during syncing for repeated instance....

* CQ-4351961 cherry-picked 96456c2 to check inner repeatable function....

* CQ-4351961 incorporated minor review comments.......

* CQ-4352213 - [AF V2] Fix submission failure when context path is set (#477)

* Rectified id duplication in widgets of components [CQ-4351961] (#471)

---------
Co-authored-by: Nitin Gupta <[email protected]>

* recategorised components for replace behaviour

* Revert "Rectified id duplication in widgets of components [CQ-4351961] (#471)" (#484)

This reverts commit 3ddecef.

* Fix redirect Thankyou Message for contextRoot (#486)

* CQ-4352213 - [AF V2] Fix submission failure when context path is set

* Added Test case for getContextPath

* Incorporating review comments

* Incorporating review comments

* Made getContextPath private

* Fix redirect Thankyou Message for contextRoot

* Formatted-code

* Incorporating review comments

* Added null check for contextPath

* @trivial Removing sdk inline jar (#493)

* FORMS-3020 Reset with repeatability. FORMS-2952 Modify addInstance/removeInstance rule.

* FORMS-3020 Reset with repeatability. FORMS-2952 Modify addInstance/removeInstance rule.

* fixed typo

* Adding fd:version in form container proxy component (#499)

Co-authored-by: ujjgupta <[email protected]>

* FORMS-3589 Enable responsiveness for forms guide container component. (#498)

* FORMS-3589 Enable responsiveness for forms guide container component.

* Fixing wizard tab navigation flaky test.

---------

Co-authored-by: Sakshi Arora <[email protected]>

* @trivial Upgrade af core (#504)

* CQ-4350777 adding data model in v2 container (#474)

* CQ-4350777 adding data model in v2 container
---------

Co-authored-by: Shivam Agarwal <[email protected]>

* Repeatability In TabsOnTop (#502)

* CQ-4348351 added repeatability In TabsOnTop and some basic refactoring of view class........

* [CQ-4348351] made a minor change to rectify test failures....

* [CQ-4348351] added changes to use childView's Id for markup manipulation rather than ancestor travelling, also incorporated review comments

* CQ-4348351 added changes to cache closestElements only when view is completely loaded and in sync with model

* [CQ-4348351] added private fields in tabs view and constants for id suffixes as suggested in review....

* [CQ-4348351] added private fields in tabs view and constants for id suffixes as suggested in review....

* [CQ-4348351] trivial change to remove hardcoding from test case....

* [CQ-4348351] added changes to optimize caching logic of closestRepeatable/nonrepeatable fields and finding the index to insert when all instances are removed from view

* [CQ-4348351] added comments for better readability of different scenarios of repeatability

---------

Co-authored-by: Deep Prakash Dewanji <[email protected]>
Co-authored-by: Deep Prakash Dewanji <[email protected]>

* CQ-4350933 - Expose GuideBridge API (#466)

* CQ-4350933 trigger elementFocusChanged event on guidebridge

* CQ-4350933 refactor and null checks

* CQ-4350933 elementHelpShown elementErrorShown, submitStart events

* CQ-4350933 get form name in json, some refactoring

* CQ-4350933 fixing test data

* CQ-4350933 use formId and Title instead of name

---------

Co-authored-by: barshatr <[email protected]>

* Repeatability support in wizard  (#507)

* [FORMS-2961] adding repeatability support in wizard

* [FORMS-2961] optimized caching logic of closest repeatable/nonrepeatable Fields

---------

Co-authored-by: Deep Prakash Dewanji <[email protected]>
Co-authored-by: Deep Prakash Dewanji <[email protected]>

* @trivial Fixing flaky test (#510)

* @trivial Fixing flaky test

* @trivial Fixing flaky test

* @trivial Updating test collateral

---------

Co-authored-by: Talmiz Ahmed <[email protected]>
Co-authored-by: sakshi-arora1 <[email protected]>
Co-authored-by: Sakshi Arora <[email protected]>
Co-authored-by: Talmiz Ahmed <[email protected]>
Co-authored-by: Deep Prakash Dewanji <[email protected]>
Co-authored-by: Deep Prakash Dewanji <[email protected]>
Co-authored-by: Nitin Gupta <[email protected]>
Co-authored-by: Ravisanker E <[email protected]>
Co-authored-by: Deep Prakash Dewanji <[email protected]>
Co-authored-by: Gulshan Mishra <[email protected]>
Co-authored-by: Gulshan Mishra <[email protected]>
Co-authored-by: Ujjwal Gupta <[email protected]>
Co-authored-by: ujjgupta <[email protected]>
Co-authored-by: Shivam Agarwal <[email protected]>
Co-authored-by: Shivam Agarwal <[email protected]>
Co-authored-by: Barshat Rai <[email protected]>
Co-authored-by: barshatr <[email protected]>
This reverts commit 6e6aed2.

Co-authored-by: barshatr <[email protected]>
[FORMS-7152] - File attachment Prefill bug with tests (#539)
rismehta and others added 27 commits November 2, 2023 18:31
* @releng moving to latest aem image

* Updating wcm component version
@im-shiv im-shiv changed the base branch from master to dev December 6, 2023 10:24
@im-shiv im-shiv closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.