Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed default value for date not showing in authoring #967

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

egmox
Copy link
Contributor

@egmox egmox commented Nov 1, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b939c3e) 80.29% compared to head (2c83c67) 80.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #967   +/-   ##
=========================================
  Coverage     80.29%   80.29%           
  Complexity      729      729           
=========================================
  Files            89       89           
  Lines          2045     2045           
  Branches        271      271           
=========================================
  Hits           1642     1642           
  Misses          251      251           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egmox egmox force-pushed the FORMS-10894-default_date_value_authoring branch 4 times, most recently from fa7373c to 91cda31 Compare November 7, 2023 15:56
@egmox egmox force-pushed the FORMS-10894-default_date_value_authoring branch from 91cda31 to 8956a68 Compare November 15, 2023 06:21
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 85 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@egmox egmox force-pushed the FORMS-10894-default_date_value_authoring branch from 8956a68 to ff524d7 Compare December 11, 2023 06:58
Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@egmox egmox force-pushed the FORMS-10894-default_date_value_authoring branch from ff524d7 to 2c83c67 Compare December 12, 2023 06:34
@rismehta rismehta merged commit 3f21ec1 into dev Dec 12, 2023
5 checks passed
@rismehta rismehta deleted the FORMS-10894-default_date_value_authoring branch December 12, 2023 07:48
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
barshat7 pushed a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants