-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed default value for date not showing in authoring #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #967 +/- ##
=========================================
Coverage 80.29% 80.29%
Complexity 729 729
=========================================
Files 89 89
Lines 2045 2045
Branches 271 271
=========================================
Hits 1642 1642
Misses 251 251
Partials 152 152 ☔ View full report in Codecov by Sentry. |
dmaurya929
reviewed
Nov 2, 2023
fa7373c
to
91cda31
Compare
91cda31
to
8956a68
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
8956a68
to
ff524d7
Compare
rismehta
reviewed
Dec 11, 2023
rismehta
reviewed
Dec 11, 2023
.../main/content/jcr_root/apps/core/fd/components/form/datepicker/v1/datepicker/datepicker.html
Outdated
Show resolved
Hide resolved
rismehta
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comments
ff524d7
to
2c83c67
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Gulshan Mishra <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Gulshan Mishra <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: Gulshan Mishra <[email protected]>
barshat7
pushed a commit
that referenced
this pull request
Feb 7, 2024
Co-authored-by: Gulshan Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: