-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics to the sync manager #244
Conversation
This PR adds metrics to the sync manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good!
@evanfoster I tried to run all the tests under /pkg/monitoring and they seem to be running fine:
What issues are you seeing when running these tests? And what do you mean by "seem to run far more often than they should, and they don't seem to run under the correct package"? |
@aalexandru I just thought i was seeing my tests run more frequently than I thought they should have. I'm not very good at parsing the output of Go's unit testing, so it's probably just a brain fart on my part. |
Description
This PR adds metrics to the new sync manager component. I've tried to find the metrics that will allow us to identify/meaningfully alert on issues with the sync manager, but I haven't had much experience with implementing metrics—Please question any choices I've made if the motivation behind them isn't clear.
Additionally, I may need some help getting the unit tests to run correctly. Right now, the
monitoring/manager/metrics_test.go
tests seem to run far more often than they should, and they don't seem to run under the correct package.