Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/service metadata fixes 2 #90

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

aalexandru
Copy link
Member

Add a check for available GVKs using a discovery client. If a configured GVK isn't installed on the cluster it will skip it instead of returning an error.

Improve field parsing for servicemetadatawatcher.spec.watchedServiceObjects.watchedFields.src:

  • remove "last" as a possible index value, replaced with support for negative indexes (e.g., -1 is the last, -2 second to last etc.)
  • add support for maps (e.g., metadata.annotations[some.key/example])
  • refactored parsing logic to (hopefully) make it easier to understand

@aalexandru aalexandru requested a review from a team as a code owner November 21, 2023 16:25
@aalexandru aalexandru merged commit f2f8883 into adobe:main Nov 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant