Support reply-after for 429 & 503 responses #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresbott
approved these changes
Apr 2, 2024
| @@ -76,7 +76,8 @@ type Response struct { | |||
| // The raw body of the HTTP response. | |||
| Body []byte | |||
| // The value of the X-Debug-Id header. | |||
| XDebugID string | |||
| XDebugID string | |||
| RetryAfter string | |||
There was a problem hiding this comment.
food for though, you looked more into the usage of retry after.
from my view it makes sense extract the returned time and parse it into a date-time type directly in the client, instead of delegating this responsibility to the caller.
|
I include an update of the jwt lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the reply-after header.
Add tests for reply-after and x-debug-id header parsing