Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-167030-follow up for milo refactoring of federals #212

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

SonjaPopovic
Copy link
Collaborator

@SonjaPopovic SonjaPopovic commented Feb 4, 2025

Copy link

aem-code-sync bot commented Feb 4, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (4981171) to head (08f3373).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #212   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files          14       14           
  Lines        3698     3698           
=======================================
  Hits         3033     3033           
  Misses        665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ben-Zahler
Copy link
Collaborator

this looks simple enough, so I'm in favor of merging it even before our go-live.
@SonjaPopovic can you check why Nala tests are failing? thx!

@SonjaPopovic
Copy link
Collaborator Author

SonjaPopovic commented Feb 4, 2025

this looks simple enough, so I'm in favor of merging it even before our go-live. @SonjaPopovic can you check why Nala tests are failing? thx!

They are failing because milo pr is not merged yet (and on this branch we have imports that are not valid without that pr changed). I added do-not-merge so once when milo pr is merged will retriger nala tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants