Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-167119 - channelpartner is broken on iOS15 on XCode simulator #213

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

richardhand-fortedigital
Copy link
Collaborator

@richardhand-fortedigital richardhand-fortedigital commented Feb 4, 2025

https://jira.corp.adobe.com/browse/MWPW-167119

Test URL:
https://MWPW-167119-regex-older-support--dme-partners--adobecom.hlx.page/channelpartners/home/

- replaces regex lookahead with group capture
Copy link

aem-code-sync bot commented Feb 4, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@richardhand-fortedigital richardhand-fortedigital marked this pull request as ready for review February 4, 2025 17:37
Copy link

aem-code-sync bot commented Feb 4, 2025

Page Scores Audits
📱 /channelpartners/home/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /channelpartners/home/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (4981171) to head (557b3d9).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #213   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files          14       14           
  Lines        3698     3698           
=======================================
  Hits         3033     3033           
  Misses        665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ben-Zahler Ben-Zahler merged commit fa5f6d2 into stage Feb 5, 2025
11 checks passed
@Ben-Zahler Ben-Zahler deleted the MWPW-167119-regex-older-support branch February 5, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants