-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addon/components/paper-checkbox): converts to a glimmer component. #1305
Open
matthewhartstonge
wants to merge
2
commits into
feature/glimmer-paper-grid-tile
Choose a base branch
from
feature/glimmer-paper-checkbox
base: feature/glimmer-paper-grid-tile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(addon/components/paper-checkbox): converts to a glimmer component. #1305
matthewhartstonge
wants to merge
2
commits into
feature/glimmer-paper-grid-tile
from
feature/glimmer-paper-checkbox
+175
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
This was referenced Nov 13, 2024
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
November 14, 2024 02:57
1ad715a
to
1e72457
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
2 times, most recently
from
November 14, 2024 03:53
188a5f5
to
d563cbd
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
November 15, 2024 02:50
1e72457
to
9f3982b
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
2 times, most recently
from
November 15, 2024 02:58
7d3f8be
to
d089999
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
November 17, 2024 22:22
5b35c04
to
3496e2a
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
November 17, 2024 22:22
d089999
to
9a84adb
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
December 17, 2024 03:22
9a84adb
to
a765f74
Compare
matthewhartstonge
changed the base branch from
feature/glimmer-paper-item
to
feature/glimmer-paper-grid-tile
December 17, 2024 03:22
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
from
December 30, 2024 09:24
05d7c66
to
abb2f48
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
December 30, 2024 09:40
a765f74
to
896adac
Compare
Some tests with 'continue-on-error: true' have failed:
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
hero-davidm
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title says it all!