feat(addon/components/paper-radio): converts radio components to glimmer components. #1309
+403
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
48e2b74 to
7d3f8be
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-radio
branch
from
c1875b0 to
f5c7e3c
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
7d3f8be to
d089999
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-radio
branch
from
f5c7e3c to
d86233e
Compare
20 tasks
20 tasks
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
d089999 to
9a84adb
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-radio
branch
from
82495fa to
9982aba
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-checkbox
branch
from
9a84adb to
a765f74
Compare
matthewhartstonge
changed the base branch from
feature/glimmer-paper-checkbox
to
feature/glimmer-paper-item
matthewhartstonge
force-pushed
the
feature/glimmer-paper-radio
branch
from
04fc025 to
949f337
Compare
…different implementations.
matthewhartstonge
force-pushed
the
feature/glimmer-paper-item
branch
from
6061018 to
d8e8c1e
Compare
Previously, `@checked` could be overridden due to how ember overrides properties with whatever is passed in.
…@checked` was able to be manually overridden.
…ing `@checked` directly.
matthewhartstonge
force-pushed
the
feature/glimmer-paper-radio
branch
from
949f337 to
48b6aae
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.