Enhance the environment variable check #5800
Conversation
Check environment variable as set only if it's not empty. Signed-off-by: Sophia Guo <[email protected]>
|
Using macros "set-property" checking both the presence of the property and whether it is non-empty to handle the case where the env.variable might be set but empty. |
|
Could you please test the change in Grinder? |
|
Grinder shows the change won't affect current behaviour. This change mainly handle the environment variable is set but empty, which seems can only trigger in this environment #5683 (comment). Set environment variable as empty in jenkinsfilebase https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L83 won't trigger this issue. Fix and causes is similar to https://github.com/adoptium/TKG/pull/641/files. Given the high cost of setting up this test environment ( trigger the dynamic agent, might also need to use George's PR) and current behaviour won't be changed I'm skipping the test the environment variable is set but empty. If any issues arise late we can address them at that time. |
|
I tested openJcePlusTests in 2 scenarios (Grinder_FIPS/2896, Grinder_FIPS/2897) and they both passed. Unfortunately, I cannot test all the cases. But I think this PR is safe to merge. |
Check environment variable as set only if it's not empty.
Related #5683 (comment)