Build apk workflow update #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I forgot that page existed. I suppose it is unnecessary in that case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Android build workflows to use
upload-artifact@v4due to@v3being deprecated on January 30, 2025 (which is tomorrow at the time of this writing). Theupload-artifactchanges can be seen in this GitHub blog post: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/The
upload-pages-artifactis also updated according to https://github.com/actions/upload-pages-artifact to ensure that is on the most up to date version. This workflow updates the page hosted at https://advplyr.github.io/audiobookshelf-app/. I wonder if we still need this page because it is not really advertised anywhere and the APK can be downloaded from the workflow itself. However, the page is very nice and looks professional, but not sure about maintaining it if it breaks. A screenshot of the page is shown below.