Support rich text descriptions #2176
Open
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rich text descriptions were added in 2.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2161
This uses the trix editor that's currently used to include rich text for podcast episodes to enable rich text in book descriptions, and preserves descriptions grabbed from iTunes, Audible, and epubs in html. A
descriptionPlainfield is also returned by compatible providers so that the description preview when searching in match tab doesn't show html tags.Additionally, the current description line in the match tab is truncated with css and shows the full description when hovering.
To preserve compatibility, html is stripped from the descriptions when embedding metadata in audio files.
The hover text for buttons doesn't seem to work if
getDefaultHTMLis provided as it is currently to remove unused toolbar buttons, so I also hardcoded the button labels.Also, this is literally the first thing I've done with javascript so I'm probably not the right person to do this but I tried anyway, hopefully this doesn't cause too much annoyance!
resolves #617
resolves #1820