-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFO metadata source #2305
Add NFO metadata source #2305
Conversation
Unit test now committed. |
Can you share one or more sample NFO files so I can test and that we can add to the guide? I don't remember seeing an NFO with an audiobook before |
Here are a few examples: nfo examples.zip |
I thought it made more sense to trim the metadata description after it gets parsed.
Another thing to note with the description is that it has to be placed last or the rest of the NFO file will be included in the description. This looked intentional on your part and it works for me but I just wanted to highlight that. I don't see a better way of handling it. |
Thanks! |
Sounds good.
Indeed, it was intentional. Thanks for the thorough review! |
In many cases, audiobooks come with .nfo files. While there's no standard to this text format, most audiobook .nfo files follow some de-facto standards specifying metadata (e.g. "Title", "Author", "Read by"). In some cases the .nfo files have metadata attributes that are missing/wrong in the folder structure or the audio meta tags.
This adds NFO as an additional metadata source, parsing the .nfo files according to the de-facto standards.
I put the NFO default priority just above audio meta tags, which I find reasonable, but this could be of course changed if needed.
I also have unit test for the parser. If you approve PR #2300, I'll commit that as well.