Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audiobook converter library specific settings #2472

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nichwall
Copy link
Contributor

@nichwall nichwall commented Jan 2, 2024

This PR is designed to help make the Audiobook File Management Tools more useful by adding more information to the Audio Tracks table and adding a new library specific setting for default encoding values for the "advanced settings". It is a WIP while I learn more about how JS and Vue work.

I'm okay if somebody takes this and runs with it since I won't be very fast.

  • Add bitrate column
  • Set default bitrate to be the maximum bitrate of the existing files (so everything isn't hard coded to 128k)
  • Add database table of default encoder settings as library setting
    • Use [max/min/fixed] bitrate
    • [Keep channels/force stereo/force mono]
    • Codec: [aac, opus], maybe more?
    • File format: [m4b, mp3]
  • Use library specific settings in file management tools

bitrate_column

The default encoding values will include information that can be reused for both audiobooks and podcasts. The default encoding values can then be applied to an entire library, individual library items (book or podcast episodes), or a grouping of library items (podcast). This PR will not include automatic encoding, but hopefully helps provide better support once queueing or automatic conversion is added.

(pardon the terrible mockup, but something kind of like this. Image will be replaced once I get the actual tab built)
automatic_encoding_mockup

@nichwall
Copy link
Contributor Author

nichwall commented Jan 3, 2024

A better description is included here. This PR should be good to merge as is to help with setting the bitrate automatically based on the input files and otherwise is purely a minor interface update.

#2479

@slyfoxgh
Copy link

slyfoxgh commented Jan 4, 2024

I think it looks straightforward. A simple setting of bitrate and preferred codec as the default option is good. I would use a global setting of 64K AAC for all books. I usually manually set 128 for radio drama based books that have music or sound effects.

@FreedomBen
Copy link
Contributor

Merging the automatic birate settings soon would be awesome. I've forgotten to check/adjust the bitrate a number of times so I have dozens of books that are 128k encoded from 64k sources 😅

@nichwall nichwall force-pushed the converter_bitrate_stats branch from e4dbc61 to 71ab302 Compare June 29, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants