Use musl-based libnusqlite3 in Docker #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's okay. Tested on all my machines. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @devnoname120's advice, I am switching to a musl-based nunicode sqlite extension on Docker, and doing away with installing and relying on gcompat (which is no longer needed). The new musl-based binaries are obtained from the new v1.2 version of nunicode-binaries.
Other nunicode binaries remain unchanged, but I switched to v1.2 in BinaryManager as well, to keep the versions consistent.
Note: BinaryManager doesn't check the exact linux version and always installs the standard glibc-based version. This means that running if you run on a non-Docker Alpine (probably as a developer), you will have to install gcomapt manually for the program to load. I think this is OK, but let me know if you want me to add a special use-case for Alpine in BinaryManager.
I tested on Docker on both architectures.