Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and simplify filter logic for publishedDecades #3518

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

glorenzen
Copy link
Contributor

This adds a small change to the publishedDecades filter query to allow for decades before 1000 and simplifies it a bit as well.

@advplyr
Copy link
Owner

advplyr commented Oct 15, 2024

This wasn't working in my testing. The client was crashing because a number was getting added to the filter in libraries.js instead of a string.
When padding the string with 0 the query wasn't working for years < 1000.

Since using string comparison isn't going to work well I updated it to cast to integer. That's not ideal but maybe in the future we update that column to integer.

@advplyr advplyr merged commit 61b4cfd into advplyr:master Oct 15, 2024
5 checks passed
@glorenzen
Copy link
Contributor Author

Ah, got it. I see why the updates you made were needed, but now I'm confused how it worked when I tested it.

Oh well. Thanks for the fixes!

@pwinnski
Copy link

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants