Add podcastId index to podcastEpisodes #3528
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have roughly 40k podcast episodes on around 200 podcasts, and performance was becoming an issue. I noticed the only index on
podcastEpisodes
wascreatedAt
. Since joins are frequently done betweenpodcasts
andpodcastEpisodes
this will slow things down quite a bit without an index. There is a foreign key constraint, but AFAIK sqlite3 does not create an index for FKs automatically.This change adds an index on
podcastEpisodes.podcastId
. It improves performance (loading time) for me on the/library/......
,/library/.../bookshelf
, and/library/...../podcast/latest
webpagesI am not a JS dev. I looked through the migration code, and it seems like the addition of an index should migrate, but I am unsure.
Feel free to ask questions, or I'm on discord too (mggw)