-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to create ereaders #3531
Allow users to create ereaders #3531
Conversation
This is generally working well for me and the correct devices show up for the user with limited editing if they are not the sole user who can access it. I did find some problems using the following tests. Test 1:
Test 2:
|
I was able to reproduce both issues and actually found another while doing that. These issues happened because I last minute decided to remove shared ereaders from the payload so that if a user uses the API they can't be a bad actor/unintentionally update any shared ereaders.
|
Solid, thanks! |
Allow users to create ereaders
This is an enhancement feature that should close issue #1982 when merged. The purpose is to allow self-serve of the ereader devices by users of an Audiobookshelf instance. Personally, I'd much rather pass on the handling of ereader devices to the users themselves. Since it's disabled by default, it won't have any effect on current instances and only those who would like to utilize the feature can now have the opportunity to.
What's Changed
Client
Server
createEreader
permission for users with default false except for admin / root/api/me/ereader-devices
Screenshots
User account page with createEreader permission
Admin users page with new toggle