Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cilium v1.16.5 #576

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update Cilium v1.16.5 #576

merged 1 commit into from
Jan 15, 2025

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Jan 15, 2025

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

  • Chores

    • Updated Cilium package from version 1.16.4 to 1.16.5
    • Updated image tags and digests for Cilium agent, Hubble relay, and Cilium operator
    • Modified configuration files to reflect new version
  • New Features

    • Added internal address configuration for Envoy listeners with specific CIDR ranges

Signed-off-by: Andrei Kvapil <[email protected]>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 15, 2025
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

Walkthrough

This pull request updates the Cilium package from version 1.16.4 to 1.16.5. The changes encompass multiple files including Chart.yaml, README.md, values.yaml, Dockerfile, and a configuration file for Cilium Envoy. The primary modifications involve updating version tags, image digests, and a minor configuration adjustment in the Hubble relay service address format. These updates ensure the package uses the latest version of Cilium with corresponding image references.

Changes

File Change Summary
charts/cilium/Chart.yaml Updated appVersion and version from 1.16.4 to 1.16.5
charts/cilium/README.md Updated image digests for agent, clustermesh API server, Hubble relay, and preflight images to v1.16.5
charts/cilium/files/cilium-envoy/configmap/bootstrap-config.json Added internal_address_config with CIDR ranges for internal addresses
charts/cilium/templates/hubble-relay/configmap.yaml Added a period before port in peer-service address
charts/cilium/values.yaml Updated image tags and digests for Cilium agent, Hubble relay, Cilium operator, and clustermesh API server to v1.16.5
images/cilium/Dockerfile Updated VERSION argument from v1.16.4 to v1.16.5

Possibly related PRs

Suggested labels

size:S, enhancement

Suggested reviewers

  • klinch0

Poem

🐰 Hop, hop, version update time!
Cilium's numbers now climb
From 1.16.4 to 1.16.5 we go
Digests and tags in a smooth flow
A rabbit's tech dance, oh so sublime! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34d6ab0 and 3478750.

📒 Files selected for processing (6)
  • packages/system/cilium/charts/cilium/Chart.yaml (2 hunks)
  • packages/system/cilium/charts/cilium/README.md (8 hunks)
  • packages/system/cilium/charts/cilium/files/cilium-envoy/configmap/bootstrap-config.json (3 hunks)
  • packages/system/cilium/charts/cilium/templates/hubble-relay/configmap.yaml (1 hunks)
  • packages/system/cilium/charts/cilium/values.yaml (7 hunks)
  • packages/system/cilium/images/cilium/Dockerfile (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • packages/system/cilium/images/cilium/Dockerfile
  • packages/system/cilium/charts/cilium/Chart.yaml
  • packages/system/cilium/charts/cilium/README.md
🔇 Additional comments (12)
packages/system/cilium/charts/cilium/templates/hubble-relay/configmap.yaml (1)

19-19: LGTM! The addition of trailing dot follows DNS best practices.

The change makes the peer-service address a fully qualified domain name (FQDN) by adding a trailing dot, which prevents unintended DNS search domain appendix and ensures deterministic DNS resolution.

Let's verify this change aligns with Cilium's documentation:

packages/system/cilium/charts/cilium/files/cilium-envoy/configmap/bootstrap-config.json (2)

55-78: LGTM: Configuration structure is consistent

The internal_address_config is properly structured and consistently applied across all three listeners, following Envoy's configuration schema.

Also applies to: 146-169, 236-259


55-78: Security enhancement: Internal network access restrictions added

The addition of internal_address_config to all listeners enhances security by explicitly defining trusted internal networks. This change restricts access to metrics, admin, and health endpoints to only private networks and loopback addresses.

Please verify that these CIDR ranges cover all your internal networks:

  • Private networks: 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16
  • Loopback: 127.0.0.1/32, ::1/128

Also applies to: 146-169, 236-259

packages/system/cilium/charts/cilium/values.yaml (9)

156-156: Version update looks good.

The Cilium agent version update from v1.16.4 to v1.16.5 is a patch release, which should maintain backward compatibility.


159-159: Image digest update is consistent.

The new SHA256 digest ensures the integrity of the Cilium agent image v1.16.5.


1317-1317: Hubble relay version is in sync.

The Hubble relay version matches the Cilium agent version (v1.16.5), maintaining consistency across components.


1319-1319: Hubble relay digest is updated correctly.

The new SHA256 digest ensures the integrity of the Hubble relay image v1.16.5.


2168-2168: Envoy version update is aligned.

The Envoy proxy version has been updated to match the new Cilium release.


2170-2170: Envoy digest is updated correctly.

The new SHA256 digest ensures the integrity of the Envoy proxy image.


2483-2483: Operator version is in sync.

The Cilium operator version matches the agent version (v1.16.5), maintaining consistency across components.


2485-2491: Operator digests are updated for all providers.

The SHA256 digests for all Cilium operator variants (Generic, Azure, AWS, and AlibabaCloud) have been updated to match v1.16.5.


Line range hint 156-2491: Verify no remaining references to the old version.

Let's ensure there are no remaining references to v1.16.4 in the codebase.

✅ Verification successful

Version update to v1.16.5 is complete and consistent

All Cilium components have been properly updated to v1.16.5 with their corresponding image digests. No references to the previous version remain in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to the old version
# This helps ensure the update was complete and consistent

echo "Checking for any remaining v1.16.4 references..."
rg -i "v1\.16\.4" || echo "No old version references found."

echo "Verifying all expected v1.16.5 references are present..."
rg -i "v1\.16\.5"

Length of output: 2605


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps kvaps merged commit b246f9d into main Jan 15, 2025
2 checks passed
@kvaps kvaps deleted the cilium-v1.16.5 branch January 15, 2025 12:58
@dosubot dosubot bot added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant