Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/implement service spec #124

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Feat/implement service spec #124

merged 14 commits into from
Apr 23, 2024

Conversation

sergeyshevch
Copy link
Member

@sergeyshevch sergeyshevch commented Apr 6, 2024 •
edited by kvaps
Loading

Fixes #115
Fixes #166

@sergeyshevch sergeyshevch self-assigned this Apr 6, 2024
sircthulhu
sircthulhu requested changes Apr 6, 2024
View reviewed changes
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/etcdcluster_types.go Outdated Show resolved Hide resolved
internal/controller/factory/metadata.go Outdated Show resolved Hide resolved
@sircthulhu sircthulhu added the feature New feature or request label Apr 6, 2024
@sergeyshevch sergeyshevch force-pushed the feat/implement-service-spec branch from 0bb1d1f to 97745a4 Compare April 14, 2024 10:38
sircthulhu
sircthulhu approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sergeyshevch sergeyshevch marked this pull request as draft April 20, 2024 08:52
@sergeyshevch sergeyshevch force-pushed the feat/implement-service-spec branch from 97745a4 to dd19281 Compare April 20, 2024 09:13
@sergeyshevch sergeyshevch force-pushed the feat/implement-service-spec branch from dd19281 to 688faf2 Compare April 22, 2024 16:24
@sergeyshevch sergeyshevch marked this pull request as ready for review April 22, 2024 16:50
kvaps
kvaps requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also could you please update dnsNames in

/examples/manifests/etcdcluster-kamaji.yaml
/examples/manifests/etcdcluster-with-external-certificates.yaml

@sergeyshevch sergeyshevch requested a review from kvaps April 22, 2024 17:12
@sergeyshevch sergeyshevch enabled auto-merge (squash) April 22, 2024 19:02
@sergeyshevch sergeyshevch disabled auto-merge April 23, 2024 08:06
@sergeyshevch sergeyshevch enabled auto-merge (squash) April 23, 2024 08:07
@sergeyshevch sergeyshevch merged commit 7f761b6 into main Apr 23, 2024
8 checks passed
@sergeyshevch sergeyshevch deleted the feat/implement-service-spec branch April 23, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddenmarten hiddenmarten hiddenmarten approved these changes

@Kirill-Garbar Kirill-Garbar Kirill-Garbar approved these changes

@kvaps kvaps kvaps approved these changes

@AlexGluck AlexGluck Awaiting requested review from AlexGluck

@sircthulhu sircthulhu Awaiting requested review from sircthulhu

Assignees

@sergeyshevch sergeyshevch

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename services (breaking) Add serviceTemplate
5 participants
@sergeyshevch @sircthulhu @kvaps @Kirill-Garbar @hiddenmarten