Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt AEP-155: Idempotency #77

Merged
merged 9 commits into from
Dec 20, 2023
Merged

Adopt AEP-155: Idempotency #77

merged 9 commits into from
Dec 20, 2023

Conversation

rofrankel
Copy link
Collaborator

This is a pretty straightforward adoption of Google's AIP-155. The only substantial change is the renaming of the field from request_id to idempotency_key. See the new subsection of the Rationale section for an explanation.

@rofrankel rofrankel requested a review from a team as a code owner November 22, 2023 05:29
toumorokoshi
toumorokoshi reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments. main question to me is about whether we should better define how long an idempotency key is valid for?

aep/general/0155/aep.yaml Show resolved Hide resolved
aep/general/0155/aep.yaml Outdated Show resolved Hide resolved
aep/general/0155/aep.yaml Outdated Show resolved Hide resolved
aep/general/0155/aep.md Show resolved Hide resolved
aep/general/0155/aep.md Outdated Show resolved Hide resolved
aep/general/0155/aep.md Outdated Show resolved Hide resolved
toumorokoshi
toumorokoshi approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main nit at this point is about the guidance on a minimum (still don't see it).

Also I'd consider my comment on the formats accepted by idempotency key. But not going to block further.

aep/general/0155/aep.md Outdated Show resolved Hide resolved
aep/general/0155/aep.md Outdated Show resolved Hide resolved
aep/general/0155/aep.yaml Show resolved Hide resolved
aep/general/0155/aep.md Outdated Show resolved Hide resolved
gibson042
gibson042 reviewed Nov 30, 2023
View reviewed changes
aep/general/0155/aep.md Outdated Show resolved Hide resolved
rofrankel
rofrankel commented Dec 14, 2023
View reviewed changes
Copy link
Collaborator Author

@rofrankel rofrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying with notes from yesterday's meeting.

aep/general/0155/aep.md Outdated Show resolved Hide resolved
@rofrankel rofrankel merged commit 3f21cc1 into main Dec 20, 2023
2 checks passed
@rofrankel rofrankel deleted the idempotency branch December 20, 2023 19:59
@gibson042 gibson042 mentioned this pull request Dec 28, 2023
Open
toumorokoshi pushed a commit to toumorokoshi/aep.dev that referenced this pull request Jan 10, 2024
@rofrankel @toumorokoshi
Adopt AEP-155: Idempotency (aep-dev#77)
08b1f63 
* Adopt AEP-155: Idempotency

* Address Yusuke's comments.

* Update aep/general/0155/aep.md

* lint

* Qualify proto-specific guidance.

* Update to reflect new common components and live discussion.

* Minor rephrasing of list.

* Clarify invalid `first_sent`.

* Remove section about stale success responses.
toumorokoshi pushed a commit to toumorokoshi/aep.dev that referenced this pull request Jan 24, 2024
@rofrankel @toumorokoshi
Adopt AEP-155: Idempotency (aep-dev#77)
f7d100a 
* Adopt AEP-155: Idempotency

* Address Yusuke's comments.

* Update aep/general/0155/aep.md

* lint

* Qualify proto-specific guidance.

* Update to reflect new common components and live discussion.

* Minor rephrasing of list.

* Clarify invalid `first_sent`.

* Remove section about stale success responses.
@mkistler mkistler mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 left review comments

@mkistler mkistler mkistler left review comments

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rofrankel @toumorokoshi @mkistler @gibson042