Cli #19
Merged
Cli #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated on 3.12 but re-introduced on 3.13
Jegp
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Overall, some really really nice comments. I'm slightly concerned about the verbosity of the flags for the CLI commands. I predict we'll have some headaches synchronizing the Python or CLI API in the future. I don't have any better suggestions, though. Except for more introspection, which I really wouldn't go for at this point in time :-)
Super nice work with the processing/job API. That will make my life a lot easier, I predict.
LGTM! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.