chore(tx-builder): prefer a schema with optional ver instead max ver

aeternity · Dec 12, 2023 · b8087d8 · b8087d8
1 parent 7e6c587
commit b8087d8
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/tx/builder/index.ts b/src/tx/builder/index.ts
@@ -8,7 +8,9 @@ import { txSchema } from './schema';
 import { TxUnpacked, TxParams, TxParamsAsync } from './schema.generated';
 import { Tag } from './constants';
 import { buildContractId, readInt } from './helpers';
-import { ArgumentError, DecodeError, SchemaNotFoundError } from '../../utils/errors';
+import {
+  ArgumentError, DecodeError, InternalError, SchemaNotFoundError,
+} from '../../utils/errors';
 
 /**
  * JavaScript-based Transaction builder
@@ -17,7 +19,11 @@ import { ArgumentError, DecodeError, SchemaNotFoundError } from '../../utils/err
 export function getSchema(tag: Tag, version?: number): Array<[string, Field]> {
   const schemas = txSchema.filter((s) => s.tag.constValue === tag);
   if (schemas.length === 0) throw new SchemaNotFoundError(`${Tag[tag]} (${tag})`, 0);
-  version ??= Math.max(...schemas.map((schema) => schema.version.constValue));
+  if (version == null) {
+    const defaultSchema = schemas.find((schema) => schema.version.constValueOptional);
+    if (defaultSchema == null) throw new InternalError(`Can't find default schema of ${Tag[tag]} (${tag})`);
+    version = defaultSchema.version.constValue;
+  }
   const schema = schemas.find((s) => s.version.constValue === version);
   if (schema == null) throw new SchemaNotFoundError(`${Tag[tag]} (${tag})`, version);
   return Object.entries(schema);