Replace AENS methods with Name class #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
feature/refactor-name
branch
from
2014b3d to
34747d1
Compare
davidyuk
force-pushed
the
feature/refactor-name
branch
2 times, most recently
from
b688848 to
0b3d961
Compare
davidyuk
force-pushed
the
feature/refactor-name
branch
from
0b3d961 to
ad876f2
Compare
davidyuk
force-pushed
the
feature/refactor-name
branch
11 times, most recently
from
e2495bc to
837261d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1917 +/- ##
===========================================
- Coverage 80.54% 80.47% -0.07%
===========================================
Files 109 109
Lines 3655 3668 +13
Branches 782 786 +4
===========================================
+ Hits 2944 2952 +8
- Misses 384 388 +4
- Partials 327 328 +1 ☔ View full report in Codecov by Sentry. |
davidyuk
force-pushed
the
feature/refactor-name
branch
from
837261d to
07c4a8b
Compare
BREAKING CHANGE: aens* methods removed
Use Name class instead.
```diff
-await aeSdk.aensPreclaim('example.chain')
+const name = new Name('example.chain', aeSdk.getContext())
+await name.preclaim()
```
Accordingly for other methods:
```
aensRevoke => Name:revoke
aensUpdate => Name:update
aensTransfer => Name:transfer
aensQuery => Name:getState
aensClaim => Name:claim
aensBid => Name:bid
```
davidyuk
force-pushed
the
feature/refactor-name
branch
from
07c4a8b to
956daac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Crypto Foundation