Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed confirm justfile #684

Merged
merged 2 commits into from
Jan 21, 2024
Merged

fixed confirm justfile #684

merged 2 commits into from
Jan 21, 2024

Conversation

agmes4
Copy link
Member

@agmes4 agmes4 commented Jan 21, 2024

the [confrim()] was not recognised there for I wrote a confirm clause which is run befor the Database was touched

the [confrim()] was not recognised there for I wrote a confirm clause which is run befor the Database was touched
@agmes4 agmes4 added the bug label Jan 21, 2024
@agmes4 agmes4 requested a review from lukasjuhrich January 21, 2024 11:02
@agmes4 agmes4 self-assigned this Jan 21, 2024
- use shebang for easier multiline input
- use bash for easier (and correct; the double quotes were missing)
  conditions with `[[ ]]`
- use case-insensitive matching so we can answer with `j` as well¡
@lukasjuhrich
Copy link
Collaborator

Thanks! The confirm (especially with text) is a really, really new feature of just. This is much more compatible.

I fixed a few details, see 4b8eb3c.

@lukasjuhrich lukasjuhrich merged commit 4b8eb3c into develop Jan 21, 2024
4 of 5 checks passed
@lukasjuhrich lukasjuhrich deleted the f/confirm_justfile_fix branch June 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants