Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PR Workflow Testing Runs Against Main Repo Code Instead of PR Code #403

Closed
3 tasks done
XiangZhang-zx opened this issue Jan 7, 2025 · 1 comment · Fixed by #408
Closed
3 tasks done

[Bug] PR Workflow Testing Runs Against Main Repo Code Instead of PR Code #403

XiangZhang-zx opened this issue Jan 7, 2025 · 1 comment · Fixed by #408
Labels
bug report bugs that need to be fixed

Comments

@XiangZhang-zx
Copy link
Contributor

Checked other resources

  • I added a very descriptive title to this issue.
  • I am sure the issue hasn't been already addressed by searching through https://github.com/agiresearch/AIOS/issues.
  • The usage issue is not resolved by updating to the latest stable version in the main branch.

Describe your current environment

No response

Describe the bug

Description:

When submitting a PR, the GitHub workflow is triggered to run tests using the current main repository code rather than the changes in the PR code. This behavior causes issues such as:
Fixes introduced in the PR being marked as failed during workflow tests.
PRs with unresolved issues being marked as passed if the main repo code is fixed independently.

Steps to Reproduce:

Create a PR with fixes to an existing problem.
Observe that the workflow runs against the main repository's code rather than the changes in the PR.
Merge the PR into the main repository and observe that the workflow succeeds when triggered by the main repo code.

Expected Behavior:

The workflow should run tests using the PR code to ensure changes introduced in the PR are verified.

Observed Behavior:

The workflow runs using the main repository code, leading to false negatives and positives in the test results.

image image
@XiangZhang-zx XiangZhang-zx added the bug report bugs that need to be fixed label Jan 7, 2025
@XiangZhang-zx
Copy link
Contributor Author

This issue is being addressed in PR #408 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report bugs that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant