Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use PR code instead of main branch in workflow #408

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

XiangZhang-zx
Copy link
Contributor

@XiangZhang-zx XiangZhang-zx commented Jan 7, 2025

Before: Workflow always used main branch code
After: Workflow uses PR code when testing PR

PR:
image

Merged:
image

Fixes #403

XiangZhang-zx and others added 7 commits January 6, 2025 10:43
Problem: The system was using environment variables for API keys.
Solution: Changed the code to first check the config file for API keys. If not found, it falls back to environment variables.
Impact: Ensures API keys are managed centrally in the config file, improving flexibility and control.
Before: Workflow always used main branch code
After: Workflow uses PR code when testing PR
Copy link
Collaborator

@dongyuanjushi dongyuanjushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this updated workflow only triggered when PR is submitting?

@XiangZhang-zx
Copy link
Contributor Author

XiangZhang-zx commented Jan 7, 2025

the updated workflow is triggered both when a PR is submitted and after it is merged

@dongyuanjushi dongyuanjushi merged commit b511b95 into agiresearch:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PR Workflow Testing Runs Against Main Repo Code Instead of PR Code
2 participants