Cleanup to support emulator only #7
Conversation
bin/adb_server.sh
Outdated
| @@ -1,9 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| adb -P 5037 kill-server | |||
There was a problem hiding this comment.
You might want to reconsider deleting this script which ensures that adb server is running. Furthermore, the relevant part of supervisor's configuration will keep trying to run this, but will fail miserably since it's deleted.
Dockerfile
Outdated
| @@ -20,14 +20,7 @@ RUN set -xeo pipefail && \ | |||
| rm "/root/.wget-hsts" && \ | |||
| rm "/tmp/glibc.apk" "/tmp/glibc-bin.apk" && \ | |||
| curl https://sh.rustup.rs -sSf | sh -s -- -y && \ | |||
There was a problem hiding this comment.
you can remove this line as well. it installs rust as a requirement for gnirehtet
bin/adb-reconnect.sh
Outdated
| else | ||
| date > /tmp/reboot | ||
| fi | ||
| adb -s $d reconnect |
There was a problem hiding this comment.
i would keep the timeout to ensure quicker workaround, because adb command can easily get stuck for a long time
bin/device_setup.sh
Outdated
| @@ -70,14 +50,6 @@ while sleep 1; do | |||
|
|
|||
| kick_rebooter $d | |||
There was a problem hiding this comment.
unless you install the rebooter app on emulators, this can probably be removed, together with the function definition above.
bin/adb-reconnect.sh
Outdated
| @@ -2,11 +2,5 @@ | |||
|
|
|||
| while read d | |||
| do | |||
| if [ -z "$STF_PROVIDER_PUBLIC_IP" ]; then | |||
There was a problem hiding this comment.
keep in mind that despite the comment below, STF_PROVIDER_PUBLIC_IP variable is not a marker of "real devices".
mmishra-agoda
changed the base branch from
master
to
feature/reverse-tethering-tmp
# Conflicts: # Dockerfile # bin/adb-reconnect.sh # bin/device_setup.sh # bin/metrics-battery.js # cron/root # supervisor/supervisord.conf
Raikerian
changed the base branch from
feature/reverse-tethering-tmp
to
master
* test-butler-update: updated test-butler version
This reverts commit 7503a6d.
bin/device_setup.sh
Outdated
| clean_agoda_staff $d | ||
| done | ||
|
|
||
| if [ ! -z "$STF_PROVIDER_PUBLIC_IP" ]; then |
There was a problem hiding this comment.
minor comment: can be changed to -n instead.
No description provided.