Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch the deleting of change records #11

Open
wants to merge 2 commits into
base: agriwebb-merge
Choose a base branch
from

Conversation

Traksewt
Copy link

@Traksewt Traksewt commented Aug 6, 2020

Bulk the deleting of change records

  • SEMVER-MAJOR -- Backwards-incompatible changes
  • SEMVER-MINOR -- Add functionality in a backwards-compatible manner
  • [x ] SEMVER-PATCH -- Backwards-compatible bug fixes

Description of change(s)

Do the delete of change records in a single go.

Link(s) to related GitHub issues

Checklist

  • CLA signed
  • Commit message conforms with the Git commit message
    guidelines
  • New tests are added to cover all changes
  • Code passes npm test
  • Code conforms with the style
    guide
  • All CI builds are passing (semi-required, left up to discretion of the
    reviewer)

@Traksewt Traksewt requested review from jeffora and kobaska August 6, 2020 01:55
lib/persisted-model.js Outdated Show resolved Hide resolved
Co-authored-by: Kogulan Baskaran <[email protected]>
}
}
function rectifyDeleteChanges(Model, ids, cb) {
return Change.rectifyModelChanges(Model.modelName, ids, cb);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Change in scope here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants