Coerce initializer parameter to_hash or to_h when it's not a Hash #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing hash-like objects that respond to #to_h or #to_hash will no longer fail to work with lift's initializer when they didn't respond to #each_pair. Whenever we can coerce the object to be a hash, do it, rather than forcing the caller to. This can be used in situations like passing a JSON API response directly into the initializer of a class that includes Lift, to create a value object out of the JSON data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing hash-like objects that respond to #to_h or #to_hash will no longer fail to
work with lift's initializer when they didn't respond to #each_pair. Whenever we can
coerce the object to be a hash, do it, rather than forcing the caller to.
This can be used in situations like passing a JSON API response directly into the
initializer of a class that includes Lift, to create a value object out of the JSON
data.