Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the project to use Melange.
tomorrow
becomes a "universal" library, shared by native and Melange buildsyesterday
keeps being interface shared / impl specific, by copying themli
into the specific platform foldersdate
libs is just rearranged to work on both platformsBesides that:
Edited, old description:
This PR is an exploration to see if it's possible to use simplecopy#
rules to share code between Melange and native libraries.The idea is to put all shared code in a separate folder, and then add rules in the platform specific library like:One can also copy interfaces in case both implementation libs need to comply with some mli.The main downsides are:- boilerplate to create the copying rules- even if merlin can provide some type information in the shared code if it is built, it is expected to be failing as the cm*s of the modules in the implementation won't be available in the shared folder