Skip to content

Commit

Permalink
Merge pull request #155 from ahrefs/louis/pr-review-silence-comments
Browse files Browse the repository at this point in the history
Do not notify for PR review comments
  • Loading branch information
Khady authored Jul 11, 2024
2 parents 06e4b45 + 4e9872d commit 17fee13
Show file tree
Hide file tree
Showing 3 changed files with 502 additions and 26 deletions.
9 changes: 6 additions & 3 deletions lib/action.ml
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,13 @@ module Action (Github_api : Api.Github) (Slack_api : Api.Slack) = struct
partition_pr cfg n |> List.map (generate_pull_request_notification ~slack_match_func n) |> Lwt.return
| PR_review n ->
partition_pr_review cfg n |> List.map (generate_pr_review_notification ~slack_match_func n) |> Lwt.return
| PR_review_comment n ->
partition_pr_review_comment cfg n
| PR_review_comment _n ->
(* we want to silence review comments and keep only the "main" review message
TODO: make this configurable? *)
Lwt.return []
(* partition_pr_review_comment cfg n
|> List.map (generate_pr_review_comment_notification ~slack_match_func n)
|> Lwt.return
|> Lwt.return *)
| Issue n -> partition_issue cfg n |> List.map (generate_issue_notification ~slack_match_func n) |> Lwt.return
| Issue_comment n ->
partition_issue_comment cfg n |> List.map (generate_issue_comment_notification ~slack_match_func n) |> Lwt.return
Expand Down
Loading

0 comments on commit 17fee13

Please sign in to comment.