Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for failed builds channel #163

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

thatportugueseguy
Copy link
Collaborator

This PR adds a config for a failed builds channel. This is a channel where notifications for failed builds get posted with the new CI steps that were broken, with an @mention for the slack user who committed the changes that broke the CI.

Only newly broken CI steps get notified, so when a user's commit breaks a step that was already notified, it doesn't get notified again.

@Khady
Copy link
Contributor

Khady commented Oct 14, 2024

do you have a screenshot to show the final result?

@thatportugueseguy
Copy link
Collaborator Author

Screenshot 2024-10-14 at 09 17 37

Actually, looking again at the screenshot, I'm left thinking that we can make the notification more minimal and in line with the changes in #162.. We don't need to have a duplicate commit message, and we don't need the author in the commit lie, since we are identifying them in the slack mention.

@Khady
Copy link
Contributor

Khady commented Oct 15, 2024

are steps broken the new failures or all the steps that failed in a given build?

@thatportugueseguy
Copy link
Collaborator Author

only new failures. No preexisting failures are notified. On build #159 in the screenshot above, there are three failing steps, but only the two new ones are notified, with the author of the current commit in mention.

@thatportugueseguy
Copy link
Collaborator Author

I've made the notification a bit more minimal, I think it looks good. I'm happy to merge now

Screenshot 2024-10-15 at 09 22 24

@thatportugueseguy thatportugueseguy merged commit 112db89 into master Oct 16, 2024
2 of 3 checks passed
@thatportugueseguy thatportugueseguy deleted the post-fails-to-channel branch October 16, 2024 08:21
@Khady
Copy link
Contributor

Khady commented Oct 17, 2024

should we also notify when the build gets fixed?

@Khady
Copy link
Contributor

Khady commented Oct 17, 2024

can you update the documentation please

@Khady
Copy link
Contributor

Khady commented Oct 17, 2024

I guess we should have made the notification of committer optional too

@Khady
Copy link
Contributor

Khady commented Oct 17, 2024

those notifications will ony be for the main branch right?

@Khady
Copy link
Contributor

Khady commented Oct 17, 2024

those notifications will ony be for the main branch right?

They are not. I think it's a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants