-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for failed builds channel #163
Conversation
do you have a screenshot to show the final result? |
Actually, looking again at the screenshot, I'm left thinking that we can make the notification more minimal and in line with the changes in #162.. We don't need to have a duplicate commit message, and we don't need the author in the commit lie, since we are identifying them in the slack mention. |
are |
only new failures. No preexisting failures are notified. On build |
should we also notify when the build gets fixed? |
can you update the documentation please |
I guess we should have made the notification of committer optional too |
those notifications will ony be for the main branch right? |
They are not. I think it's a problem |
This PR adds a config for a failed builds channel. This is a channel where notifications for failed builds get posted with the new CI steps that were broken, with an @mention for the slack user who committed the changes that broke the CI.
Only newly broken CI steps get notified, so when a user's commit breaks a step that was already notified, it doesn't get notified again.