Add per pipeline failed builds channel config #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
reviewed
Oct 17, 2024
| (* This type of rule is used for CI build notifications. *) | ||
| type status_rules = { | ||
| ?allowed_pipelines : string list nullable; (* keep only status events with a title matching this list *) | ||
| ?failed_builds_channel: string nullable; (* channel to post failed builds notifications to *) | ||
| ?allowed_pipelines : pipeline list nullable; (* keep only status events with a title matching this list *) |
There was a problem hiding this comment.
breaking change, will have to update the config in a bunch of different repos
There was a problem hiding this comment.
I have added this adapter to support the old format across repos with the old config format. This way we can gradually update the configs and then clean this up
There was a problem hiding this comment.
please update the config documentation too
…on-channel * origin: only use failed builds chan for main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to configure different failed build channels for different pipelines and also us to have pipelines without a specific failed build channel, which will notify failures to the default channel.