Handle status notifications with multiple branches #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatportugueseguy
added a commit
that referenced
this pull request
Jan 13, 2025
…ne-commits * origin/master: Handle status notifications with multiple branches (#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
Status notifications for builds of commits that exist in multiple branches have multiple branches in the
branchesproperty of the notification, even though the build belongs to that commit on a specific branch. These branches come listed in no specific order, so there's no way to know which to which branch that build notification belongs.We extract the build number from the notification to query the buildkite API so we can handle that notification correctly and not mix states across builds and branches.
I've added a cache for the builds so that we don't have to query the buildkite API every time we get a status notification (we get around 200+ per build..)