-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraint checks #2
Conversation
* main: add licenses for vendored code
* main: add source to dune-project to fix dune subst
One remaining thing I'm not that happy about is that the plugin will check for Maybe this is fine for now, and we can think about smarter ways to find the |
Sounds good for a 0.0.1. Possible ways to improve:
|
@davesnx @anmonteiro thanks for the reviews. I think I tackled all the comments, I will merge, then work on testing OCaml 5, and then cut a first release to submit to opam. A couple of issues that originated from this PR have been created: |
This PR adds:
npm-version
variableI think this is enough to release a version to opam, the only remaining thing would be to lift the OCaml compiler constraint so that the opam plugin also works with 5.0.