Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ros2_control Dockerfile for iron #93

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Add ros2_control Dockerfile for iron #93

merged 3 commits into from
Jul 19, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jul 17, 2023

Description

This PR adds a Dockerfile for iron with updated tags for ros2 control and ros2 controllers (and all the additional annoying dependencies...).

Review guidelines

Estimated Time of Review: x minutes

@domire8 domire8 requested a review from eeberhard July 17, 2023 15:41
eeberhard
eeberhard approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job hunting down those dependencies. Looks good for now and we can then see how it affects our DSE, hw interfaces and controllers

@domire8 domire8 merged commit dbcb98f into main Jul 19, 2023
@domire8 domire8 deleted the iron branch July 19, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeberhard eeberhard eeberhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @eeberhard