Refactor component interface using node interfaces #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeberhard
approved these changes
Oct 24, 2023
Remove template class NodeT and change ComponentInterface constructor arguments to get all the node interfaces. Pass the publisher type as argument to create_output.
…rface (#38) Make qos private.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These 5 PRs have been reviewed independently and the latest commit has been tested to some extent already. How should we proceed here? Should I change the commit titles for each commit and then we fast forward those to main and test it as rolling?
I believe that this should then be modulo 4.0.0 as we have to rebuild all dynamic components with that version.
Review guidelines
Estimated Time of Review: 3 minutes
Checklist before merging: