-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in table dependencies (quicker for user and more valid) #105
Conversation
@BatoolMM @Rainiefantasy @DDelbarre - it would be great to get at least 2 of you reviewing this PR if that's possible, as it's a relatively major change for a user interaction, so I want to double check all is working fine and it cannot be broken in a way that I have not anticipated. After this PR is merged, I intend to make a new package release. Thanks in advance 🚀 Just to note: there have been a fair few changes to the code lately based on @DDelbarre's suggestions and @Rainiefantasy's review of these PRs. Main ones here: |
@Rainiefantasy thanks for the helpful testing so far 🚀
|
FYI seems like all is working - point 2 was erroring before but works fine now. I.e. all changes are working as expected 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for merge as tested changes and all looks good!
@BatoolMM and @DDelbarre I am merging for now, as Mahwish & I did a fair bit of testing and troubleshooting. Would still value any user testing you have time for in the future |
Thank you @Rainiefantasy @RayStick - thsi looks wonderful - I did a very quick test and it seems to be working well. I have blocked time tomorrow morning to review more. |
Amazing - thanks Batool! |
Closes #63
Copying from one table to the next will save the user time, and ensure consistency of categorisations across tables
Proposed Changes
domain_mapping
has been added (table_copy
) - see the description of this argument in the function itself and the explanation in the README of what table copying means (particularly lines 348 onwards)domain_mapping
docs in general, to reflect some recent changesIn order to test the code you will need to process multiple tables
This is an example of how the copying should work (ignore the actual domain code values):
Checklist before review: