Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vignette + pkgdown website #52

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Adding vignette + pkgdown website #52

merged 8 commits into from
Jan 11, 2024

Conversation

BatoolMM
Copy link
Member

@BatoolMM BatoolMM commented Jan 5, 2024

This is to fix #34

@BatoolMM BatoolMM self-assigned this Jan 5, 2024
@BatoolMM BatoolMM added the documentation Improvements or additions to documentation label Jan 5, 2024
@BatoolMM BatoolMM added this to the before-public-release milestone Jan 5, 2024
@RayStick
Copy link
Member

RayStick commented Jan 9, 2024

This looks great @BatoolMM
Let me know when it is ready to review

@BatoolMM BatoolMM changed the title Adding vignette + pkgdown website [WIP] Adding vignette + pkgdown website Jan 10, 2024
@BatoolMM
Copy link
Member Author

This will create an initial GH page for the pkg. it looks like this:

Screenshot 2024-01-10 at 18 20 30

It has "getting started" a page that goes into more detail by showing the vignettes. I added the 'Getting started with metadata' and 'Getting Started Guide for browseMetadata R Package' a bit repetitive to what already on the main page but that's expected from vignettes. It can be developed further but this initial PR is ready for review.

Screenshot 2024-01-10 at 18 23 22

Run pkgdown::build_site() to view the page locally, can't deploy it until the repo is public.

Copy link
Member

@RayStick RayStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BatoolMM
I had a quick look through and it looks good
I am not familiar with all of these steps so I don't know why all these files exist but if you are happy with the PR, please feel free to merge! We can then see if the website is working fine

@BatoolMM
Copy link
Member Author

The reason that many files modified because I used the lintr which corrected some formatting according to best practices and the other files are HTML that are generated using the YAML file for pkgdown. I will merge it now so I can test the deployment again, thank you @RayStick !

@BatoolMM BatoolMM merged commit 76ba68b into main Jan 11, 2024
1 check passed
@RayStick
Copy link
Member

The reason that many files modified because I used the lintr which corrected some formatting according to best practices and the other files are HTML that are generated using the YAML file for pkgdown. I will merge it now so I can test the deployment again, thank you @RayStick !

Yeah I could see a lot was to do with linting - all good! It was mostly the HTML stuff that I am less familiar with.
Thanks Batool =D

@BatoolMM
Copy link
Member Author

BatoolMM commented Jan 12, 2024

Hi @RayStick, the deployment is working here, I added to README.
If you clicked on 'Getting Started', you will see "Getting started with metadata" and resources you added, there is also repetition similar to main page (around how to install pkg) but I see that with other pkgs docs, we can always polish them.

The docs for the functions and data is within "References". We can also in the future add short tutorials but not priority now. I am travelling today so I won't do anything until Monday.

@RayStick
Copy link
Member

Thanks for this Batool, I can see it.
This is a great start 🚀

@RayStick RayStick deleted the doc-vignette branch February 29, 2024 16:20
@RayStick
Copy link
Member

@all-contributors add @RayStick for pull request reviews

Copy link
Contributor

@RayStick

I've put up a pull request to add @RayStick! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a vignette and pkgdown website
2 participants