-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vignette + pkgdown website #52
Conversation
This looks great @BatoolMM |
This will create an initial GH page for the pkg. it looks like this: It has "getting started" a page that goes into more detail by showing the vignettes. I added the 'Getting started with metadata' and 'Getting Started Guide for browseMetadata R Package' a bit repetitive to what already on the main page but that's expected from vignettes. It can be developed further but this initial PR is ready for review. Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BatoolMM
I had a quick look through and it looks good
I am not familiar with all of these steps so I don't know why all these files exist but if you are happy with the PR, please feel free to merge! We can then see if the website is working fine
The reason that many files modified because I used the |
Yeah I could see a lot was to do with linting - all good! It was mostly the HTML stuff that I am less familiar with. |
Hi @RayStick, the deployment is working here, I added to README. The docs for the functions and data is within "References". We can also in the future add short tutorials but not priority now. I am travelling today so I won't do anything until Monday. |
Thanks for this Batool, I can see it. |
@all-contributors add @RayStick for pull request reviews |
I've put up a pull request to add @RayStick! 🎉 |
This is to fix #34