Add process calibration and simulator app [WIP] #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhermida
commented
Jan 26, 2025
| } | ||
| } | ||
|
|
||
| let thresholds: Vec<i32> = min_values.iter() |
There was a problem hiding this comment.
I did it in Python first, I guess this looks like a port to Rust 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass to the calibration. I've done a small simulator app to test it locally without the hardware.
I put the
process_calibrationwithinlibsnot sure if it's the best approach for that but it looks you've tried to make it modular in general.Please, as much comments as possible for a Rust newbie 😛 it feels a feel convoluted.