Skip to content

Commit

Permalink
update isinstance function, use JoinGroupResponse_v5 for check
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuaherrera committed Dec 4, 2023
1 parent d430920 commit 5c60f63
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions aiokafka/consumer/group_coordinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
OffsetFetchRequest_v1 as OffsetFetchRequest)
from aiokafka.protocol.group import (
HeartbeatRequest, JoinGroupRequest, LeaveGroupRequest,
SyncGroupRequest, JoinGroupResponse)
SyncGroupRequest, JoinGroupResponse, JoinGroupResponse_v5)
from aiokafka.structs import OffsetAndMetadata, TopicPartition
from aiokafka.util import create_future, create_task

Expand Down Expand Up @@ -409,11 +409,10 @@ async def _perform_assignment(self, response: Response):
member_metadata = {}
all_subscribed_topics = set()
for member in members:
if isinstance(response, JoinGroupResponse[3]):
if isinstance(response, JoinGroupResponse_v5):
member_id, group_instance_id, metadata_bytes = member
elif (isinstance(response, JoinGroupResponse[0]) or
isinstance(response, JoinGroupResponse[1]) or
isinstance(response, JoinGroupResponse[2])):
elif isinstance(response, (JoinGroupResponse[0], JoinGroupResponse[1],
JoinGroupResponse[2])):
member_id, metadata_bytes = member
else:
raise Exception("unknown protocol returned from assignment")

Check warning on line 418 in aiokafka/consumer/group_coordinator.py

View check run for this annotation

Codecov / codecov/patch

aiokafka/consumer/group_coordinator.py#L418

Added line #L418 was not covered by tests
Expand Down

0 comments on commit 5c60f63

Please sign in to comment.